Merged
Conversation
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
📢 Thoughts on this report? Let us know! 🚀 New features to boost your workflow:
|
snopoke
reviewed
Jun 9, 2025
SmittieC
reviewed
Jun 9, 2025
SmittieC
reviewed
Jun 11, 2025
SmittieC
reviewed
Jun 11, 2025
Co-authored-by: Simon Kelly <skelly@dimagi.com>
snopoke
reviewed
Jun 12, 2025
apps/pipelines/helper.py
Outdated
|
|
||
| # TODO: function is temporary and can be deleted after the exp -> chatbot transition is complete | ||
| def convert_non_pipeline_experiment_to_pipeline(experiment): | ||
| if experiment.assistant: |
Contributor
There was a problem hiding this comment.
nit: extra paranoid validation that we can actually migrate this before we do
Suggested change
| if experiment.assistant: | |
| if experiment.pipeline: | |
| raise ValueError(f"Experiment already has a pipeline attached: {experiment.id}") | |
| elif experiment.assistant: |
snopoke
reviewed
Jun 12, 2025
Contributor
snopoke
left a comment
snopoke
left a comment
There was a problem hiding this comment.
I think this needs to be updated with the changes from the parent branch
snopoke
previously approved these changes
Jun 13, 2025
apps/experiments/management/commands/migrate_nonpipeline_to_pipeline_experiments.py
Show resolved
Hide resolved
snopoke
previously approved these changes
Jun 18, 2025
Contributor
snopoke
left a comment
snopoke
left a comment
There was a problem hiding this comment.
Small comments but nothing blocking
Co-authored-by: Simon Kelly <skelly@dimagi.com>
Co-authored-by: Simon Kelly <skelly@dimagi.com>
snopoke
approved these changes
Jun 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
part of #1664
merges into #1721
After pressing banner button to migrate experiment. it navigates to the newly created chatbot
User Impact
users are able to migrate LLM and Assistant type experiments themselves
Demo
Docs and Changelog
yes to changelog-- the docs have information about the transition, but I may add something specifically for this migration