Skip to content

Banner js error #1733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 11, 2025
Merged

Banner js error #1733

merged 1 commit into from
Jun 11, 2025

Conversation

stephherbers
Copy link
Contributor

Description

noticed a JS error on prod-- it doesn't like parsing the params and I figured we didn't need them anyways

User Impact

banners can close!

Demo

n/a

Docs and Changelog

n/a

@stephherbers stephherbers requested review from snopoke and SmittieC June 10, 2025 22:34
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@snopoke snopoke merged commit 1b4f013 into main Jun 11, 2025
9 checks passed
@snopoke snopoke deleted the smh/js-error branch June 11, 2025 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants