Iterative version of getFlattenedTree for improved performance on large datasets #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cireo
reviewed
Apr 22, 2021
|
|
||
| for (const node of nodes) { | ||
| flattenNodes.push({node, parents}); | ||
| } |
There was a problem hiding this comment.
could be
const flattenNodes = nodes.map((node) => {node, parents});
|
Any updates for this PR? |
|
I think maintainers aren't following PRs, last update to the repo was last September =(. Might have to fork or monkey-patch if you want it. A little investigation on the last merged PR reveals that the owner became a father, so they probably reprioritized correctly! |
|
A long shot but any possibility of this being merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #84
Thank you for the great library, it has worked really well and achieved amazing results with our project.
Recently, we had a performance issue with a particularly large dataset. The tree contained roughly 140k nodes with the structure being 14 nodes containing around 10k direct children each.
This would take around 1-2 minutes to render.
Quick profiling showed that
getFlattenedTreewas taking around 1 minute to complete.After changing the
getFlattenedTreeto an iterative implementation, the render time decreased drastically with profiling showing allgetFlattenedTreecalls completing within 100ms.Would appreciate any comments or thoughts