Support git insteadOf config entries during import #267
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The works with git config insteadOf entries
Contributor
|
Would probably be good and easy enough to add a test here: https://github.com/dirk-thomas/vcstool/blob/master/test/test_commands.py |
Not available in 3.5
Author
|
Ty for reminding me about tests. The extra output I added broke them. Will update. |
Additional output breaks tests
Git doesn't make it easy to override the location of the global gitconfig file. Maybe I should just write the .gitconfig directly, to avoid any chance over overwriting the user's gitconfig https->ssh would be more annoying as then you have to deal with ssh keys, making sure they exist, unlocking, etc.
Avoid any potential shell issues that might result in the user's real .gitconfig being touched.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ls-remote --get-url will apply any special insteadOf rules. This prevents false "Path already exists and contains a different repository" errors if you have something like the below in your gitconfig.