-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: description of the project #20
Conversation
README.md
Outdated
|
||
## Contributing | ||
|
||
You’re welcome to help ! Please read the [**DisMoi** Contributing Guidelines](https://github.com/dis-moi/backend/blob/master/CONTRIBUTING.md). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you a create a generic CONTRIBUTING.md as suggested there instead please?
dis-moi/.github#1
I suppose once created, it will be visible on this repository as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should I do the same for the backend readme and the extension readme?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you talking about the updates you mades on backend contributing?
About having a generic CONTRIBUTING.md
for all repositories I would love to <3
Not sure what's the best way to implements it tho, for example:
- Shall we have a specific
CONTRIBUTING.md
in each repository - when required - and link to the generic one?
Or - Shall we leverage the
.github
mechanism and have the sameCONTRIBUTING.md
for all repositories and add all the specificities of a project in anothermd
(README.md
, suggestions?) file?
cc @dis-moi/devs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By intuition, I'm more tempted by your second question (.github mechanism)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@felix-lambert no need, just for this repo is good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is far beyond my expectations, loving it!
Could just provide a generic contributing guide? This can be done later tho, I'm approving this 👍
Cool for this PR I will not merge before everyone approves :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic work @felix-lambert ! I say merge it :) then we can share with the team!
Co-authored-by: Christian <[email protected]>
I did'nt go too far because the doc of Julien might be included as a link to this Readme