Add Guild#retrieveMemberVoiceState
#2729
Open
+111
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/main/java/net/dv8tion/jda/internal/entities/EntityBuilder.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Austin Keener <[email protected]>
Co-authored-by: Austin Keener <[email protected]>
Co-authored-by: Florian Spieß <[email protected]>
src/main/java/net/dv8tion/jda/internal/entities/EntityBuilder.java
Outdated
Show resolved
Hide resolved
| { | ||
| EntityBuilder entityBuilder = jda.getEntityBuilder(); | ||
| DataObject voiceStateData = response.getObject(); | ||
| MemberImpl member = entityBuilder.createMember(this, voiceStateData.getObject("member"), voiceStateData, null); |
There was a problem hiding this comment.
I would not pass the voice state to createMember here since it will become stale and inconsistent.
|
|
||
| final long channelId = voiceStateJson.getLong("channel_id"); | ||
| final long channelId = newVoiceStateJson.getLong("channel_id"); | ||
| AudioChannel audioChannel = (AudioChannel) guild.getGuildChannelById(channelId); | ||
| if (audioChannel != null) | ||
| ((AudioChannelMixin<?>) audioChannel).getConnectedMembersMap().put(member.getIdLong(), member); |
There was a problem hiding this comment.
We should avoid updating the channel connected members cache unless we actually cache voice states, otherwise this cache is incredibly unreliable.
…java Co-authored-by: Florian Spieß <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Etiquette
Changes
Closes Issue: NaN
Description
Discord recently added an API endpoint to get a user's voice state in a guild (https://discord.com/developers/docs/resources/voice).
Adds
Guild#retrieveMemberVoiceState,Guild#retrieveMemberVoiceStateById(long)andGuild#retrieveMemberVoiceStateById(String)that send a request and create a newGuildVoiceStateif not already cached.Also makes changes to
EntityBuilderto allow the creation of voice states from JSON andRoutefor the new endpoint.