Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace GatewayIntent#GUILD_EMOJIS_AND_STICKERS with GUILD_EXPRESSIONS #2755

Merged

Conversation

freya022
Copy link
Contributor

@freya022 freya022 commented Oct 16, 2024

Pull Request Etiquette

Changes

  • Internal code
  • Library interface (affecting end-user code)
  • Documentation
  • Other: _____

Closes Issue: NaN

Description

Updates the intent to match Discord's name, will be clearer for #2753

@MinnDevelopment
Copy link
Member

If the user does not migrate to the new intent, and has activated cache flags that require the GUILD_EXPRESSIONS intents, the cache flags will get disabled and a warning will be logged.

I don't think it will be disabled, since the check will include both regardless. I'll consider writing a test for this.

@freya022
Copy link
Contributor Author

freya022 commented Nov 1, 2024

True, as it uses the raw intents, it sees both the old and new intent enabled.

@MinnDevelopment MinnDevelopment merged commit 53adaa1 into discord-jda:master Nov 3, 2024
1 check passed
@freya022 freya022 deleted the rename-to-guild-expressions branch November 3, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants