Add Opus. #3022
Open
Add Opus. #3022
+1,913
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also note, this code is part of my other project/library (OpusSharp) however I have added it for freedom of use for Discord.NET |
… attribute instead for AOT compatibility. Needed to also convert net6.0 to net7.0 to support LibraryImport attribute.
|
As a user I would love to see this implemented! |
|
Some functions still aren't correct. I'm still going through them and double checking them as well as documenting them. I will update the pr after I finish some tests on the fixes I've made. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I've added nearly all of the opus's functions and implemented safe handlers for thread safety and reference safety. So it is easier to dispose of opus native objects using an IDisposable wrapper implementation.
Things that are missing are CTL definitions and Error Codes however these can optionally be implemented. Also this code only works with libopus v1.5 and above.
If you want, I can add all the opus cross platform binaries or workflow to this project.
Changes
Related Issues
N.A.