[octocrab] Allow committer to be Author *or* GitUser #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nataliejameson
changed the title
In some cases it seems the Compare Commits endpoint (`/repos/{owner}/{repo}/compare/{base}...{head}`) will return *either* a full Author object for committer and author of each commit *or* just the name, email, etc that are in GitUser. This appears to be the case when e.g. a bot does the commit that github cannot tie to a user specifically? In any case, this change allows us to deserialize that commit comparison endpoint's results while also allowing us to get full information if it's available.
Also bump the version
nataliejameson
force-pushed
the
nmj/git-user-instead-of-author
branch
from
6d4b8a7 to
4870b13
Compare
todpunk
approved these changes
Apr 16, 2025
denbeigh2000
approved these changes
Apr 16, 2025
nataliejameson
added a commit
that referenced
this pull request
May 1, 2025
In #4 , this was changed from Author -> GitUser. Prefer to allow both of these so we can pull user logins for commits without having to guess from their email.
nataliejameson
added a commit
that referenced
this pull request
May 2, 2025
In #4 , this was changed from Author -> GitUser. Prefer to allow both of these so we can pull user logins for commits without having to guess from their email.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases it seems the Compare Commits endpoint (
/repos/{owner}/{repo}/compare/{base}...{head}) will return either a full Author object for committer and author of each commit or just the name, email, etc that are in GitUser. This appears to be the case when e.g. a bot does the commit that github cannot tie to a user specifically? In any case, this change allows us to deserialize that commit comparison endpoint's results while also allowing us to get full information if it's available.