Skip to content

[subs] add useACOM boolean field to determine whether to use advancedCommerceData or requestData as the custom option key when purchasing#3

Merged
charleschen merged 1 commit into12.16.3-discordfrom
subs/acom-update-purchase
Nov 19, 2025
Merged

[subs] add useACOM boolean field to determine whether to use advancedCommerceData or requestData as the custom option key when purchasing#3
charleschen merged 1 commit into12.16.3-discordfrom
subs/acom-update-purchase

Conversation

@charleschen
Copy link

@charleschen charleschen commented Oct 30, 2025

Priority P1

What

  • add a optional boolean field to determine whether to make API calls to ACOM or APB

Why

  • this enables us to migrate to ACOM from APB

Tests

  • untested code, we still don't have access to ACOM yet

Task

  • Complexity or size of the PR is reasonable for efficient review
  • All new code is typed
  • All new code has been unit tested as much as possible
  • Areas for refactoring or improvement are pointed out for follow-up tasks (can be done as a comment on the area)

@charleschen charleschen requested a review from tjmabey November 13, 2025 20:01
@charleschen charleschen marked this pull request as ready for review November 13, 2025 20:01
@charleschen charleschen force-pushed the subs/acom-update-purchase branch 2 times, most recently from bbdbe45 to fb2e188 Compare November 18, 2025 21:39
…dCommerceData` or `requestData` as the custom option key when purchasing
@charleschen charleschen force-pushed the subs/acom-update-purchase branch from fb2e188 to 5d752e3 Compare November 19, 2025 03:34
@charleschen charleschen merged commit 9807491 into 12.16.3-discord Nov 19, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants