Skip to content

fix(InteractionResponses): check if ephemeral message flag is used #10021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 4, 2023
Merged

fix(InteractionResponses): check if ephemeral message flag is used #10021

merged 1 commit into from
Dec 4, 2023

Conversation

sdanialraza
Copy link
Member

Please describe the changes this PR makes and why it should be merged:
Resolves #10020

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@vercel Vercel
Copy link

vercel bot commented Dec 3, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview Dec 4, 2023 4:35pm
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Dec 4, 2023 4:35pm

@sdanialraza sdanialraza marked this pull request as ready for review December 3, 2023 17:18
@sdanialraza sdanialraza requested a review from a team as a code owner December 3, 2023 17:18
vladfrangu
vladfrangu requested changes Dec 3, 2023
View reviewed changes
Copy link
Member

@vladfrangu vladfrangu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deferReply needs this treatment too

@Jiralite Jiralite added this to the discord.js 14.15 milestone Dec 3, 2023
didinele
didinele requested changes Dec 3, 2023
View reviewed changes
didinele
didinele requested changes Dec 4, 2023
View reviewed changes
Copy link
Member

@didinele didinele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You haven't addressed Vlad's comment

@vladfrangu
Copy link
Member

You haven't addressed Vlad's comment

Nothing to address haha, iirc deferReply doesnt support all flags

@sdanialraza
Copy link
Member Author

Yeah, it was addressed internally, there's no flags property for options in deferReply

@Jiralite Jiralite self-requested a review December 4, 2023 20:02
@Jiralite Jiralite removed the blocked label Dec 4, 2023
@kodiakhq kodiakhq bot merged commit 62e31cb into discordjs:main Dec 4, 2023
@sdanialraza sdanialraza deleted the fix/check-if-ephemeral-message-flag-is-used branch December 4, 2023 20:16
@whizbangpop whizbangpop mentioned this pull request May 25, 2024
Open
@RobinSquared RobinSquared mentioned this pull request May 25, 2024
Closed
@HowlingArcher HowlingArcher mentioned this pull request May 25, 2024
Open
@ZeroXClem ZeroXClem mentioned this pull request Aug 12, 2024
Closed
@AlexEKinney AlexEKinney mentioned this pull request Aug 15, 2024
Open
@Azzraya Azzraya mentioned this pull request Aug 15, 2024
Open
This was referenced Aug 15, 2024
Open
Open
@AlexEKinney AlexEKinney mentioned this pull request Aug 18, 2024
Open
@Azzraya Azzraya mentioned this pull request Aug 18, 2024
Open
@HowlingArcher HowlingArcher mentioned this pull request Aug 19, 2024
Open
@AlexEKinney AlexEKinney mentioned this pull request Aug 19, 2024
Open
@Azzraya Azzraya mentioned this pull request Aug 19, 2024
Open
@HowlingArcher HowlingArcher mentioned this pull request Aug 20, 2024
Open
@AlexEKinney AlexEKinney mentioned this pull request Aug 20, 2024
Open
@Azzraya Azzraya mentioned this pull request Aug 20, 2024
Open
@HowlingArcher HowlingArcher mentioned this pull request Aug 21, 2024
Open
@AlexEKinney AlexEKinney mentioned this pull request Aug 21, 2024
Open
@Azzraya Azzraya mentioned this pull request Aug 21, 2024
Open
@HowlingArcher HowlingArcher mentioned this pull request Aug 22, 2024
Open
@whizbangpop whizbangpop mentioned this pull request Aug 22, 2024
Open
@Azzraya Azzraya mentioned this pull request Aug 22, 2024
Open
@AlexEKinney AlexEKinney mentioned this pull request Aug 22, 2024
Open
@HowlingArcher HowlingArcher mentioned this pull request Aug 28, 2024
Open
@AlexEKinney AlexEKinney mentioned this pull request Aug 28, 2024
Open
@Azzraya Azzraya mentioned this pull request Aug 28, 2024
Open
This was referenced Aug 30, 2024
Open
Open
@jshuntley jshuntley mentioned this pull request Sep 1, 2024
Open
@HowlingArcher HowlingArcher mentioned this pull request Sep 2, 2024
Open
@jshuntley jshuntley mentioned this pull request Sep 2, 2024
Open
@AlexEKinney AlexEKinney mentioned this pull request Sep 2, 2024
Open
@Azzraya Azzraya mentioned this pull request Sep 2, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladfrangu vladfrangu vladfrangu approved these changes

@didinele didinele didinele approved these changes

@Jiralite Jiralite Jiralite approved these changes

@iCrawl iCrawl Awaiting requested review from iCrawl iCrawl is a code owner automatically assigned from discordjs/core

@kyranet kyranet Awaiting requested review from kyranet kyranet is a code owner automatically assigned from discordjs/core

@SpaceEEC SpaceEEC Awaiting requested review from SpaceEEC SpaceEEC is a code owner automatically assigned from discordjs/core

Assignees
No one assigned
Labels
interactions packages:discord.js semver:patch
Projects
discord.js
Archived in project
Milestone
discord.js 14.15
Development

Successfully merging this pull request may close these issues.

Specifying flags: MessageFlags.Ephemeral in interaction responses does not update the ephemeral property on the interaction
4 participants
@sdanialraza @vladfrangu @didinele @Jiralite