fix: Skip sweeping if the guild is not available #10070
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
added 3 commits
January 4, 2024 09:06
Qjuh
reviewed
Jan 4, 2024
|
BTW I was able to test/reproduce this by lowering my sweep interval to 1s, which was too soon before the bot was able to login and I got the same error. Seems fine after |
Qjuh
approved these changes
Jan 4, 2024
vladfrangu
reviewed
Jan 5, 2024
uhKevinMC
suggested changes
Jan 8, 2024
didinele
approved these changes
Jan 8, 2024
vladfrangu
approved these changes
Jan 22, 2024
kyranet
approved these changes
Jan 22, 2024
Jiralite
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
Fixes #10069. It would seem that certain properties do not get set properly if the guild is not available, so when we go to sweep them, the property is undefined (.stickers, .emojis etc). Skipping unavailable guilds on a sweep pass should resolve the issue.
Status and versioning classification:
Patch