Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: Better application command mention format approach #10639

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Jiralite
Copy link
Member

@Jiralite Jiralite commented Dec 5, 2024

Please describe the changes this PR makes and why it should be merged:
This function is handled strangely—the command id is always the last parameter, the command id is possibly undefined, etc.

This approach makes the function more understandable. For example, the id is always required, so that is the first parameter and is not possibly undefined.

I am not sure if we still want all the overloads now. Also open to using an object approach.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)

BREAKING CHANGE: The parameters of `chatInputApplicationCommandMention()` have been reordered.
Copy link

vercel bot commented Dec 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Dec 5, 2024 11:12pm
discord-js-guide ⬜️ Ignored (Inspect) Dec 5, 2024 11:12pm

Copy link

codecov bot commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.13%. Comparing base (0ac140c) to head (d5d4510).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10639   +/-   ##
=======================================
  Coverage   37.13%   37.13%           
=======================================
  Files         239      239           
  Lines       15243    15243           
  Branches     1375     1375           
=======================================
  Hits         5660     5660           
  Misses       9572     9572           
  Partials       11       11           
Flag Coverage Δ
formatters 98.91% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

3 participants