feat: components v2 in v14 #10781
Open
feat: components v2 in v14 #10781
+882
−124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
Qjuh
requested review from
vladfrangu,
kyranet and
SpaceEEC
and removed request for
a team
Qjuh
force-pushed
the
mainlib-v14/v2-components
branch
from
e6541fb to
8835fd6
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
imnaiyar
approved these changes
Feb 27, 2025
vladfrangu
requested changes
Apr 22, 2025
vladfrangu
approved these changes
Apr 23, 2025
github-project-automation
bot
moved this from Review in Progress
to Review Approved
in discord.js
sdanialraza
reviewed
Apr 23, 2025
sdanialraza
approved these changes
Apr 23, 2025
imnaiyar
reviewed
Apr 24, 2025
packages/discord.js/src/structures/interfaces/TextBasedChannel.js
Outdated
Show resolved
Hide resolved
packages/discord.js/src/structures/interfaces/TextBasedChannel.js
Outdated
Show resolved
Hide resolved
Qjuh
requested review from
ckohen,
didinele and
Jiralite
and removed request for
a team
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v14 #10781 +/- ##
=======================================
Coverage 35.51% 35.51%
=======================================
Files 228 228
Lines 14317 14319 +2
Branches 1255 1255
=======================================
+ Hits 5084 5086 +2
Misses 9189 9189
Partials 44 44
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: Naiyar <[email protected]>
didinele
approved these changes
Apr 24, 2025
| return this.components.flatMap(row => row.components).find(component => component.customId === customId) ?? null; | ||
| return ( | ||
| this.components | ||
| .flatMap(component => { |
There was a problem hiding this comment.
This flatMap callback pops up twice, maybe worth considering making it a helper somewhere
Jiralite
requested changes
Apr 24, 2025
packages/discord.js/src/structures/interfaces/TextBasedChannel.js
Outdated
Show resolved
Hide resolved
github-project-automation
bot
moved this from Review Approved
to Review in Progress
in discord.js
Co-authored-by: Jiralite <[email protected]>
Jiralite
approved these changes
Apr 24, 2025
Comment on lines
+188
to
+191
| /** | ||
| * @external APIMessageTopLevelComponent | ||
| * @see {@link https://discord-api-types.dev/api/discord-api-types-v10/interface/APIMessageTopLevelComponent} | ||
| */ |
There was a problem hiding this comment.
Suggested change
| /** | |
| * @external APIMessageTopLevelComponent | |
| * @see {@link https://discord-api-types.dev/api/discord-api-types-v10/interface/APIMessageTopLevelComponent} | |
| */ | |
| /** | |
| * @external APIMessageTopLevelComponent | |
| * @see {@link https://discord-api-types.dev/api/discord-api-types-v10#APIMessageTopLevelComponent} | |
| */ |
github-project-automation
bot
moved this from Review in Progress
to Review Approved
in discord.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
Implements Components v2 into mainlib v14.
Only raw JSON data is supported yet, builders not included.
Depends on
Will need a builders v1 release too, since that discord-api-types PR is breaking and some types builders use have been renamed. But since builders v1 is on another branch it has to be another PR.
TODO: uncomment the currently commented type tests that fail because of wrong builders version once builders PR is done, merged and released; also bump builders version to that release.
Status and versioning classification: