-
-
Notifications
You must be signed in to change notification settings - Fork 4k
feat: message structures #10982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: message structures #10982
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #10982 +/- ##
==========================================
- Coverage 44.76% 43.05% -1.72%
==========================================
Files 316 373 +57
Lines 18162 19235 +1073
Branches 1811 1869 +58
==========================================
+ Hits 8130 8281 +151
- Misses 10020 10942 +922
Partials 12 12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ckohen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looking pretty good, some docstring errors and a couple things to discuss so far.
Also overall discussion, should we doc every param like types and kinda mainlib do rn. So many of them are very self-explanatory (especially the substructure ones) but I think we probably should do a lot of it anyways?
packages/structures/src/messages/components/ActionRowComponent.ts
Outdated
Show resolved
Hide resolved
818d975 to
a457ab0
Compare
ckohen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not quite through everything yet, but here's some stuff
Also I know it's brand new but we're missing the Label component
packages/structures/src/messages/components/NonPremiumButton.ts
Outdated
Show resolved
Hide resolved
packages/structures/src/messages/components/ChannelSelectMenuComponent.ts
Show resolved
Hide resolved
packages/structures/src/messages/components/SectionComponent.ts
Outdated
Show resolved
Hide resolved
packages/structures/src/messages/components/MediaGalleryComponent.ts
Outdated
Show resolved
Hide resolved
packages/structures/src/messages/components/UnfurledMediaItem.ts
Outdated
Show resolved
Hide resolved
ckohen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only a few more from the rest of the files
packages/structures/src/messages/ApplicationCommandInteractionMetadata.ts
Outdated
Show resolved
Hide resolved
packages/structures/src/messages/components/FileUploadComponent.ts
Outdated
Show resolved
Hide resolved
packages/structures/src/messages/components/NonPremiumButton.ts
Outdated
Show resolved
Hide resolved
| SuperTemplate; | ||
| } | ||
|
|
||
| export function dateToDiscordISOTimestamp(date: Date) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've been meaning to ask, but why? Discord just does normal ISO strings, not this...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are you going by documentation (ISO strings is not a single format, both this and JS toISO satisfy the ISO) or did you look at an actual payload?
Discussion about this is from https://discord.com/channels/222078108977594368/1145525943411155045/1425880899592917162 to https://discord.com/channels/222078108977594368/1145525943411155045/1425958049138475080
Please describe the changes this PR makes and why it should be merged:
Status and versioning classification: