Skip to content

Conversation

@Qjuh
Copy link
Member

@Qjuh Qjuh commented Jul 12, 2025

Please describe the changes this PR makes and why it should be merged:

  • depends on release of discord-api-types 0.38.31

Status and versioning classification:

@vercel
Copy link

vercel bot commented Jul 12, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
discord-js Ignored Ignored Preview Nov 12, 2025 9:08am
discord-js-guide Ignored Ignored Preview Nov 12, 2025 9:08am

@codecov
Copy link

codecov bot commented Jul 12, 2025

Codecov Report

❌ Patch coverage is 22.77140% with 875 lines in your changes missing coverage. Please review.
✅ Project coverage is 43.05%. Comparing base (5619137) to head (e569a99).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
packages/structures/src/polls/Poll.ts 2.56% 38 Missing ⚠️
packages/structures/src/messages/Reaction.ts 2.70% 36 Missing ⚠️
packages/structures/src/messages/MessageCall.ts 2.94% 33 Missing ⚠️
...ures/src/messages/components/TextInputComponent.ts 2.94% 33 Missing ⚠️
packages/structures/src/stickers/Sticker.ts 3.33% 29 Missing ⚠️
...tures/src/messages/components/UnfurledMediaItem.ts 3.57% 27 Missing ⚠️
...res/src/messages/components/SelectMenuComponent.ts 3.70% 26 Missing ⚠️
...ckages/structures/src/messages/MessageReference.ts 0.00% 22 Missing ⚠️
packages/structures/src/messages/ChannelMention.ts 4.54% 21 Missing ⚠️
...res/src/messages/components/FileUploadComponent.ts 4.54% 21 Missing ⚠️
... and 47 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10982      +/-   ##
==========================================
- Coverage   44.76%   43.05%   -1.72%     
==========================================
  Files         316      373      +57     
  Lines       18162    19235    +1073     
  Branches     1811     1869      +58     
==========================================
+ Hits         8130     8281     +151     
- Misses      10020    10942     +922     
  Partials       12       12              
Flag Coverage Δ
structures 53.14% <22.77%> (-32.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@ckohen ckohen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looking pretty good, some docstring errors and a couple things to discuss so far.

Also overall discussion, should we doc every param like types and kinda mainlib do rn. So many of them are very self-explanatory (especially the substructure ones) but I think we probably should do a lot of it anyways?

@github-project-automation github-project-automation bot moved this from Todo to Review in Progress in discord.js Aug 20, 2025
@Qjuh Qjuh force-pushed the feat/more-structures branch from 818d975 to a457ab0 Compare October 5, 2025 09:57
@Qjuh Qjuh marked this pull request as ready for review October 10, 2025 15:09
@Qjuh Qjuh requested a review from a team as a code owner October 10, 2025 15:09
@Qjuh Qjuh requested a review from ckohen October 12, 2025 06:40
Copy link
Member

@ckohen ckohen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not quite through everything yet, but here's some stuff

Also I know it's brand new but we're missing the Label component

Copy link
Member

@ckohen ckohen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a few more from the rest of the files

@ckohen ckohen requested a review from a team October 14, 2025 14:10
@Qjuh Qjuh removed the blocked label Oct 24, 2025
@Jiralite Jiralite added this to the structures v1 milestone Oct 25, 2025
@Qjuh Qjuh requested a review from Jiralite October 26, 2025 08:44
SuperTemplate;
}

export function dateToDiscordISOTimestamp(date: Date) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been meaning to ask, but why? Discord just does normal ISO strings, not this...

Copy link
Member Author

@Qjuh Qjuh Nov 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you going by documentation (ISO strings is not a single format, both this and JS toISO satisfy the ISO) or did you look at an actual payload?

Discussion about this is from https://discord.com/channels/222078108977594368/1145525943411155045/1425880899592917162 to https://discord.com/channels/222078108977594368/1145525943411155045/1425958049138475080

@Qjuh Qjuh requested a review from vladfrangu November 2, 2025 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Review in Progress

Development

Successfully merging this pull request may close these issues.

4 participants