Skip to content

refactor(WebSocketManager)!: remove deprecated rest option #10998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

almeidx
Copy link
Member

@almeidx almeidx commented Jul 16, 2025

BREAKING CHANGE: The rest option in the WebSocketManager constructor has been removed. Pass a fetchGatewayInformation function instead.

BREAKING CHANGE: The `rest` option in the `WebSocketManager` constructor has been removed. Pass a `fetchGatewayInformation` function instead.
@almeidx almeidx requested review from a team as code owners July 16, 2025 23:15
@almeidx almeidx requested review from kyranet and SpaceEEC July 16, 2025 23:15
Copy link

vercel bot commented Jul 16, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview Jul 17, 2025 6:46pm
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Jul 17, 2025 6:46pm

@didinele
Copy link
Member

Have we merged any other major ws PRs?

@Jiralite
Copy link
Member

Have we merged any other major ws PRs?

Copy link

codecov bot commented Jul 17, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 44.38%. Comparing base (1dfc511) to head (3ac843a).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
packages/ws/src/ws/WebSocketManager.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10998      +/-   ##
==========================================
- Coverage   44.42%   44.38%   -0.05%     
==========================================
  Files         308      308              
  Lines       17585    17565      -20     
  Branches     1749     1746       -3     
==========================================
- Hits         7813     7796      -17     
+ Misses       9759     9757       -2     
+ Partials       13       12       -1     
Flag Coverage Δ
core 0.88% <ø> (ø)
ws 35.83% <0.00%> (-0.20%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

5 participants