fix: Channel Name ratelimit make channel.edit functions freeze #11000
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes and Justification:
This PR adjusts the request handler to avoid unnecessary sublimit blocking when editing a channel. Currently, editing a channel name three times triggers a sublimit rate limit. Following that, all subsequent
channel.edit()
calls (even ones not modifying the name) are queued behind the rate limit, which is incorrect.This PR ensures that
channel.edit()
requests which do not modify thename
field are not blocked by the name change sublimit. This improves compliance with Discord's rate-limiting behavior and prevents unrelated modifications (e.g., permissions, user limits, etc.) from being delayed.Status and versioning classification: