refactor!: make RedisBroker require consumer name #11001
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11001 +/- ##
==========================================
- Coverage 44.42% 44.42% -0.01%
==========================================
Files 308 308
Lines 17585 17583 -2
Branches 1749 1749
==========================================
- Hits 7813 7811 -2
Misses 9759 9759
Partials 13 13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
didinele
changed the title
iCrawl
reviewed
Jul 18, 2025
Co-authored-by: Noel <[email protected]>
This was referenced Jul 18, 2025
Qjuh
reviewed
Jul 19, 2025
| maxChunk: 10, | ||
| blockTimeout: 5_000, | ||
| } as const satisfies Required<Omit<RedisBrokerOptions, 'group'>>; | ||
| } as const satisfies Required<Omit<RedisBrokerOptions, 'group' | 'name'>>; |
There was a problem hiding this comment.
From a docs perspective it would be better to have name and group be in their own interface and have the options interfaces extend both interfaces and have another interface only extending the one contained in these defaults. Omit is always bad for docs. Apart from that this LGTM
Jiralite
approved these changes
Jul 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In anticipation for TSR, I'm cooking some brokers stuff up again for the future.
While working on the Redis brokers, I realized that it's non-sense to default
name, it was a wrong assumption I came with from RabbitMQ.To spare some docs reading, a Redis consumer group (what we use under the hood) is used when you want to have multiple clients that see a sub set of the messages (evidently what we want with our brokers). The
namehere (or consumer name) identifies each one. If a client were to crash and restart automatically, with the user not providing thenameargument, Redis ends up potentially leaving some messages in purgatory that were already assigned to the old name.There's some more resilience I've noted we can add (like checking if there's messages in purgatory caused by a service downscale), but considering those tasks are relatively complex (low LOC diffs, but can have deep impact), I'm gonna split my PRs.
I've also used this one to update the outdated README examples.