Skip to content

Conversation

@sdanialraza
Copy link
Member

Please describe the changes this PR makes and why it should be merged:

@vercel
Copy link

vercel bot commented Oct 9, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
discord-js Ignored Ignored Preview Oct 9, 2025 6:25pm
discord-js-guide Ignored Ignored Preview Oct 9, 2025 6:25pm

@codecov
Copy link

codecov bot commented Oct 9, 2025

Codecov Report

❌ Patch coverage is 36.20690% with 37 lines in your changes missing coverage. Please review.
✅ Project coverage is 44.16%. Comparing base (0c2975e) to head (66fe4bb).
⚠️ Report is 130 commits behind head on main.

Files with missing lines Patch % Lines
...ackages/structures/src/applications/Application.ts 42.00% 29 Missing ⚠️
...ructures/src/bitfields/ApplicationFlagsBitField.ts 0.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11163      +/-   ##
==========================================
- Coverage   44.19%   44.16%   -0.03%     
==========================================
  Files         313      315       +2     
  Lines       18093    18151      +58     
  Branches     1796     1798       +2     
==========================================
+ Hits         7996     8017      +21     
- Misses      10085    10122      +37     
  Partials       12       12              
Flag Coverage Δ
structures 82.76% <36.20%> (-2.44%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Jiralite Jiralite added this to the structures v1 milestone Oct 25, 2025
Comment on lines +23 to +31
/**
* {@inheritDoc Structure.[kPatch]}
*
* @internal
*/
public override [kPatch](data: Partial<APIApplication>) {
return super[kPatch](data);
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/**
* {@inheritDoc Structure.[kPatch]}
*
* @internal
*/
public override [kPatch](data: Partial<APIApplication>) {
return super[kPatch](data);
}

This was a left-over from previous drafts for /structures and is not needed, since inheritance already causes exactly this.

@github-project-automation github-project-automation bot moved this from Todo to Denied in discord.js Jan 23, 2026
@Jiralite
Copy link
Member

Superseded by #11393.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Denied

Development

Successfully merging this pull request may close these issues.

4 participants