add "opus/silk/arm/NSQ_neon.c" to the "target_arch==\"arm64\"" condit… #166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion in opus/deps/binding.gyp
Contributor
|
@vladfrangu Can this get reviewed and merged? |
Member
|
Is this needed? I've been able to use it on macos M1 without this 👀 |
Contributor
Interesting, I'm targeting |
Member
|
If you can get us a repro dockerfile or such that'd be lovely too! Including the JS code to test locally 🙏 |
This comment was marked as off-topic.
This comment was marked as off-topic.
vladfrangu
approved these changes
Jul 6, 2025
Member
vladfrangu
left a comment
vladfrangu
left a comment
There was a problem hiding this comment.
I doubt it'll hurt to have this but we'll see I guess
Contributor
|
Any chance we can get a release published with this merged change? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
## Description
Fixes
dyld: missing symbol calledon macOS and apple siliconas reported in #165