ci: simplify and fix arm64 build #180
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orgads
force-pushed
the
ci-fix-arm
branch
3 times, most recently
from
f8d9dc9 to
7dacb99
Compare
orgads
force-pushed
the
ci-fix-arm
branch
2 times, most recently
from
56a2e37 to
8a0bdb4
Compare
|
Interesting. This uncovers a real compilation error for linux/arm64. Fixed now. https://github.com/discordjs/opus/pull/180/files#diff-ac8b87ab9e0dc323134a4867b97987a445405f227c7fcbefc9970ecb57272dc6 |
|
Notice this PR depends on: The arm changes are in a separate commit. You can review it here: 8a0bdb4 |
|
All checks passed! \o/ |
|
Rebased |
vladfrangu
reviewed
Jul 11, 2025
vladfrangu
reviewed
Jul 11, 2025
vladfrangu
previously approved these changes
Jul 11, 2025
Use Github Actions arm runner instead of cross-compiling. Avoid built-in container feature due to actions/runner#801
vladfrangu
approved these changes
Jul 11, 2025
|
Please merge it so I can rebase libopus upgrade on top of this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use Github Actions arm runner instead of cross-compiling.