Skip to content

docs: update required Node version #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 11, 2025
Merged

docs: update required Node version #181

merged 1 commit into from
Jul 11, 2025

Conversation

orgads
Copy link
Contributor

@orgads orgads commented Jul 11, 2025

Description

  • Code changes have been tested, or there are no code changes

@orgads
Copy link
Contributor Author

orgads commented Jul 11, 2025

The package does build with older Node versions, but they are no longer tested. Should we raise the engine condition in package.json as well, or allow it to be installed on older versions?

@orgads orgads mentioned this pull request Jul 11, 2025
Merged
1 task
@vladfrangu
Copy link
Member

Raise it

@orgads
Copy link
Contributor Author

orgads commented Jul 11, 2025

Done

vladfrangu
vladfrangu approved these changes Jul 11, 2025
View reviewed changes
Copy link
Member

@vladfrangu vladfrangu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably should also update the list of platform support but thats a nit, lgtm

@vladfrangu vladfrangu merged commit 2055869 into discordjs:main Jul 11, 2025
40 checks passed
@orgads orgads deleted the readme-node branch July 11, 2025 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladfrangu vladfrangu vladfrangu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@orgads @vladfrangu