DEV: Switch to new addComposerToolbarPopupMenuOption plugin API
#460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgxworld
force-pushed
the
switch_to_new_api
branch
2 times, most recently
from
785bf49
to
8439922
Compare
ZogStriP
reviewed
Oct 20, 2023
| @@ -21,7 +21,7 @@ acceptance("Post event - composer", function (needs) { | |||
| await categoryChooser.expand(); | |||
| await categoryChooser.selectRowByValue(2); | |||
| await click(".toolbar-popup-menu-options .dropdown-select-box-header"); | |||
| await click(".toolbar-popup-menu-options *[data-value='insertEvent']"); | |||
| await click(".toolbar-popup-menu-options *[data-name='Create event']"); | |||
There was a problem hiding this comment.
Would it be worth using I18n.t here instead of hard coding the text?
ZogStriP
approved these changes
Oct 20, 2023
Why this change? `api.addToolbarPopupMenuOptionsCallback` has been deprecated in discourse/discourse@913fd3a
tgxworld
force-pushed
the
switch_to_new_api
branch
from
8439922
to
9ac7ccf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this change?
api.addToolbarPopupMenuOptionsCallbackhas been deprecated in discourse/discourse@913fd3a