Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEATURE: upcoming events list component #463

Merged
merged 4 commits into from
Oct 30, 2023
Merged

FEATURE: upcoming events list component #463

merged 4 commits into from
Oct 30, 2023

Conversation

renato
Copy link
Contributor

@renato renato commented Oct 24, 2023 •
edited
Loading

Adds an Upcoming events list component, which uses the current category route to display a list of upcoming events.

image

When requesting the category events fail:
image

It is intended to be used with the Right Sidebar Blocks theme component.

When adding the component to the Right Sidebar TC, the parameters monthFormat dateFormat and timeFormat can be overridden with a different one.

pmusaraj
pmusaraj reviewed Oct 26, 2023
View reviewed changes
Copy link
Contributor

@pmusaraj pmusaraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks generally great, just a couple of small comments.

assets/javascripts/discourse/services/post-event-api.js Outdated Show resolved Hide resolved
test/javascripts/integration/components/upcoming-events-list-test.gjs Outdated Show resolved Hide resolved
assets/javascripts/discourse/components/upcoming-events-list.gjs Outdated Show resolved Hide resolved
@renato
Copy link
Contributor Author

renato commented Oct 26, 2023

Thanks for the review @pmusaraj!

@renato
Copy link
Contributor Author

renato commented Oct 26, 2023

Hey @pmusaraj, it's ready for another round when you're available. Thank you!

@renato renato requested a review from pmusaraj October 27, 2023 17:44
@renato renato mentioned this pull request Oct 29, 2023
Merged
pmusaraj
pmusaraj approved these changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@pmusaraj pmusaraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks, LGTM!

@renato renato merged commit f57b09c into main Oct 30, 2023
4 checks passed
@renato renato deleted the upcoming_events_list_component branch October 30, 2023 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmusaraj pmusaraj pmusaraj approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@renato @pmusaraj