Fully working GPay/ApplePay implementation #157
Conversation
| .filterBy("id", this.selectedPlan) | ||
| .get("firstObject"); | ||
| console.log("plan") | ||
| console.log(plan) |
There was a problem hiding this comment.
Noticing a lot of console.logs in this PR.
| const elements = this.stripe.elements(); | ||
| const paymentRequest = this.stripe.paymentRequest({ | ||
| currency: "usd", | ||
| country: "US", |
There was a problem hiding this comment.
Should country and currency be hardcoded?
| @@ -44,6 +44,18 @@ | |||
| class="btn btn-primary btn-payment" | |||
| label="discourse_subscriptions.plans.payment_button" | |||
| }} | |||
|
|
|||
| {{subscribe-payments | |||
There was a problem hiding this comment.
Can you provide a screenshot of what this would look like?
| @@ -345,6 +1197,13 @@ | |||
| "@glimmer/env" "^0.1.7" | |||
| "@glimmer/global-context" "0.83.1" | |||
|
|
|||
| "@google-pay/button-element@^3.0.6": | |||
There was a problem hiding this comment.
Is this being used in the plugin markup?
|
Yes, it was determined that the best way to work was directly through the stripe. Depending on what exactly the user's device supports, he sees the possibility of payment via GPay or Apple Pay. |
|
@blake-discourse can you make a decision on this PR please? |
|
I'm not against adding more payment option support to the checkout form, but we now support Stripe Checkout with pricing tables, and Google Pay can be enabled that way with no change to the plugin. Let's go with that route for now. |
No description provided.