Fully working GPay/ApplePay implementation #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmusaraj
reviewed
Mar 29, 2023
| .filterBy("id", this.selectedPlan) | ||
| .get("firstObject"); | ||
| console.log("plan") | ||
| console.log(plan) |
There was a problem hiding this comment.
Noticing a lot of console.logs in this PR.
| const elements = this.stripe.elements(); | ||
| const paymentRequest = this.stripe.paymentRequest({ | ||
| currency: "usd", | ||
| country: "US", |
There was a problem hiding this comment.
Should country and currency be hardcoded?
| @@ -44,6 +44,18 @@ | |||
| class="btn btn-primary btn-payment" | |||
| label="discourse_subscriptions.plans.payment_button" | |||
| }} | |||
|
|
|||
| {{subscribe-payments | |||
There was a problem hiding this comment.
Can you provide a screenshot of what this would look like?
pmusaraj
reviewed
Mar 29, 2023
| @@ -345,6 +1197,13 @@ | |||
| "@glimmer/env" "^0.1.7" | |||
| "@glimmer/global-context" "0.83.1" | |||
|
|
|||
| "@google-pay/button-element@^3.0.6": | |||
There was a problem hiding this comment.
Is this being used in the plugin markup?
|
Yes, it was determined that the best way to work was directly through the stripe. Depending on what exactly the user's device supports, he sees the possibility of payment via GPay or Apple Pay. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.