upload launcher2 to github release #886
Conversation
.github/workflows/launcher_go.yml
Outdated
| tags: | ||
| - "v*.*.*" |
There was a problem hiding this comment.
I don't think we should be using tags here to push out a release. This repository contains more than just code for launcher so a git tag would make little sense for the discourse_docker related stuff. Are we able to use some sort of version file here so that a new release is created when the version in the file is bumped?
There was a problem hiding this comment.
sure let me update to watch for that 👍
There was a problem hiding this comment.
So, short answer no it's not going to work exactly as you requested. But I've updated it so we push assets to a single release.
Github releases require a git tag, and if we don't want to provide one, we need to create a dummy tag for the release to pin to, and create a single launcher release. We can then overwrite assets within that release, and that single release becomes our go-to 'latest' release for the assets. Will that be sufficient?
featheredtoast
force-pushed
the
gh-action-upload-to-release
branch
from
ff60565
to
d07f99e
Compare
Do not use tagged releases. Upload assets to a static release named launcher2.
featheredtoast
force-pushed
the
gh-action-upload-to-release
branch
from
d07f99e
to
30e5abc
Compare
|
Updated so we're using GH CLI to upload release assets to a single static release instead of creating and uploading on a tag creation. |
featheredtoast
changed the title
|
closing in favor of discourse/launcher#1 |
create release on tag push of type
v*.*.*uploads both tar.gz and md5.
on tag creation EG, v2.0.0 this github action will:
This does not use goreleaser, or go-release-action. Creation is simple with setup go, and compilation in the shell. It then uses github cli to upload the release assets.