Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simple logging class #57

Merged
merged 4 commits into from
May 13, 2024
Merged

simple logging class #57

merged 4 commits into from
May 13, 2024

Conversation

GabrielBG0
Copy link
Collaborator

Adds a class that handles logging metrics during training, val and testing.

@GabrielBG0 GabrielBG0 added the Priority Requested Issues with priority label May 13, 2024
@GabrielBG0 GabrielBG0 requested a review from otavioon May 13, 2024 13:10
@GabrielBG0 GabrielBG0 self-assigned this May 13, 2024
@otavioon
Copy link
Collaborator

Nice work, @GabrielBG0. I made a few modifications:

  1. Since batch metrics are typically common to any model, I decided to remove the LoggedSupervisedModel and instead added train/test/validation metrics directly to SimpleSupervisedModel. It's now a dictionary with the metric name as the key and the metric implementation as the value.
  2. As previously decided, we're sticking with the torchmetrics.Metric API.
  3. I've managed to enable metrics to run on both CPU and GPU.
  4. I've added kwargs to all models inherited from SimpleSupervisedModel to allow passing metrics.
  5. Added a test of metrics usage using U-Net.

Copy link
Collaborator

@otavioon otavioon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few modifications to SimpleSupervisedModel to allow metric logging using torchmetrics.Metric API

@otavioon otavioon self-requested a review May 13, 2024 14:32
@GabrielBG0 GabrielBG0 merged commit f583936 into main May 13, 2024
1 check passed
@GabrielBG0 GabrielBG0 deleted the logging branch May 15, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority Requested Issues with priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants