Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moving models to specific folders by use #67

Merged
merged 4 commits into from
Jul 4, 2024
Merged

Moving models to specific folders by use #67

merged 4 commits into from
Jul 4, 2024

Conversation

GabrielBG0
Copy link
Collaborator

These are the changes and the modules affected:

  • Move image models to nets/image
    • deeplab.py
    • unet.py
    • vit.py
    • wisenet.py
    • setr.py
  • Move time series models to nets/time_series
    • cnn.py (is this one right?)
    • imu_transformer.py
    • inception_time.py
    • resnet.py

@GabrielBG0 GabrielBG0 requested a review from otavioon July 2, 2024 13:31
otavioon
otavioon requested changes Jul 3, 2024
View reviewed changes
Copy link
Collaborator

@otavioon otavioon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move tests to appropriated test folders/files

tests/models/nets/test_cnn_ha_etal.py Outdated Show resolved Hide resolved
tests/models/nets/test_cnn_pf.py Outdated Show resolved Hide resolved
tests/models/nets/test_deeplabv3.py Outdated Show resolved Hide resolved
tests/models/nets/test_imu_transformer.py Outdated Show resolved Hide resolved
tests/models/nets/test_inception_time.py Outdated Show resolved Hide resolved
tests/models/nets/test_resnet_1d.py Outdated Show resolved Hide resolved
tests/models/nets/test_sfm.py Outdated Show resolved Hide resolved
@otavioon
Copy link
Collaborator

otavioon commented Jul 3, 2024

Hello @GabrielBG0 , in relation to:

cnn.py (is this one right?)

Yes, it is right.

@GabrielBG0 GabrielBG0 requested a review from otavioon July 3, 2024 03:46
otavioon
otavioon approved these changes Jul 4, 2024
View reviewed changes
Copy link
Collaborator

@otavioon otavioon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GabrielBG0 GabrielBG0 merged commit 77ee77e into discovery-unicamp:main Jul 4, 2024
1 check passed
@GabrielBG0 GabrielBG0 deleted the restructuring branch July 4, 2024 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@otavioon otavioon otavioon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GabrielBG0 @otavioon