-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement a base model for LFR #70
Implement a base model for LFR #70
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some changes are needed before merging.
You should also relocate your nets to the specific use case it is intended to have, e.g. image, time series etc...
Take a look in the new model organization.
minerva/models/nets/lfr.py
Outdated
A module list with the same module `cls`, instantiated `size` times. | ||
""" | ||
|
||
def __init__(self, size, cls, *args, **kwargs): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Define types for __init__
parameters
@fernandoGubiMarques Forgot to include in the review, but if you could add the new models to the |
Neither LFR or MLP have a specific use, so I'm not sure where you want me to put them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Code looks good but i would like @otavioon 's opinion on where to put the models |
Please move |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Describe your changes
This branch contains the implementation of a base model for the Learning from Random Projectors pretext task for self-supervised learning.
This model requires two
torch.nn.ModuleList
. For convenience, aRepeatedModuleList
module is also implemented to instantiate multiple modules of the same class.Additionally, it contains an MLP class (unrelated to LFR) to facilitate the creation of future simple prediction and projection heads.
Issue ticket number and link (If apply)
Checklist before requesting a review