DDST-373: Add new fields to FOXML migration #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrismacdonaldw
added
the
minor
Also, change in the invocation recommended by Extended Analysis.
adam-vessey
reviewed
Jul 26, 2024
There was a problem hiding this comment.
Got a number of fixes together in #135 but it seems like there's other issues that are unaccounted for, such as field_subject now allowing only subject and geo_location term references, but the current mapping of subject, person and organization doesn't seem to be flagged as a gap in the MMS.
modules/dgi_migrate_foxml_standard_mods/migrations/dgis_nodes.yml
Outdated
Show resolved
Hide resolved
modules/dgi_migrate_foxml_standard_mods/migrations/dgis_nodes.yml
Outdated
Show resolved
Hide resolved
modules/dgi_migrate_foxml_standard_mods/migrations/dgis_nodes.yml
Outdated
Show resolved
Hide resolved
modules/dgi_migrate_foxml_standard_mods/migrations/dgis_nodes.yml
Outdated
Show resolved
Hide resolved
Also, prevent whatever was causing the serialization issue? Was apparently related to the "sub process" plugin naively rethrowing exceptions as `\Exception`, which would've proceeded with an undefined `$save` variable?
DDST-373: Fix some invocations
They're handled in their own dedicated fields.
Entities creates under it (instead of via stub migrations) would not be removed when rolling back.
Also, fix up the gate lock business.
nchiasson-dgi
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.