Avoid use of \SplFileInfo().
#146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It can cause arbitrary warnings emitted in underlying stream wrappers to be detected and promoted to runtime exceptions, which is rather unexpected. Warnings are warnings and not fatal errors, after all.
Forgot to use the accessor, derp.
jordandukart
approved these changes
Oct 7, 2024
jordandukart
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It can cause arbitrary warnings emitted in underlying stream wrappers to be unexpectedly detected and promoted to runtime exceptions. Warnings are warnings and not fatal errors, after all, especially when they are emitted behind the error-suppression operator.
In particular, having a
new \SplFileInfo('foxml://object/{some:pid}');, and the underlying resolution inside thefoxml://stream wrapper testing for the existence of various directories, the testing for those directories might in turn perform existence checks for various directories, which in turn cause warnings about being unable tostat()those directories that do not exist to be emitted; thereby entirely breaking the testing.