-
Notifications
You must be signed in to change notification settings - Fork 16
Multiple openapi @dataExamples #224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@@ -1,699 +1,711 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mostly lgtm, just some nitpicks
Raised issue swagger-api/swagger-ui#10503 |
I assume Swagger will take its while to acknowledge and/or implement this. For now, let's hide it behind a configuration option (in addition to the OpenAPI 3.1 gate we already have) and move on |
We don't control |
I hoped there was a mechanism to put arbitrary properties in it :( contribution idea for smithy-openapi? |
This is how it looks like after the change