feat: add support for python 3.14 and replace django-fsm to django-fsm-2#314
Open
vinitkumar wants to merge 12 commits intomasterfrom
Open
feat: add support for python 3.14 and replace django-fsm to django-fsm-2#314vinitkumar wants to merge 12 commits intomasterfrom
vinitkumar wants to merge 12 commits intomasterfrom
Conversation
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR adds Python 3.14 support across CI, project metadata, and test configurations, pins pip-tools upgrades to pip 24.3.1 with system-break flags, and migrates the finite-state machine dependency from django-fsm to django-fsm-2. Entity relationship diagram for new Python 3.14 test requirement fileserDiagram
PY311_REQUIREMENTS {
string name
string version
}
PY312_REQUIREMENTS {
string name
string version
}
PY313_REQUIREMENTS {
string name
string version
}
PY314_REQUIREMENTS {
string name
string version
}
PY314_REQUIREMENTS ||--|| PY311_REQUIREMENTS : "similar structure"
PY314_REQUIREMENTS ||--|| PY312_REQUIREMENTS : "similar structure"
PY314_REQUIREMENTS ||--|| PY313_REQUIREMENTS : "similar structure"
Class diagram for migration from django-fsm to django-fsm-2classDiagram
class FSMField {
+state
+transition()
}
class FSMField2 {
+state
+transition()
+new_features
}
FSMField <|-- FSMField2 : "django-fsm-2 replaces django-fsm"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
for more information, see https://pre-commit.ci
…to feat/python-migration-matrix
Contributor
There was a problem hiding this comment.
Hey there - I've reviewed your changes - here's some feedback:
- I don’t see any actual code changes replacing django-fsm imports or usage with django-fsm-2; please ensure your application code is updated to use the new package and remove old references.
- The new py314 requirement files are almost identical to existing ones—consider templating or generating them to avoid maintaining so many near-duplicate files in the future.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- I don’t see any actual code changes replacing django-fsm imports or usage with django-fsm-2; please ensure your application code is updated to use the new package and remove old references.
- The new py314 requirement files are almost identical to existing ones—consider templating or generating them to avoid maintaining so many near-duplicate files in the future.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Member
|
@vinitkumar Can you check why the tests fail? |
Member
Author
|
Will do. |
Filter out Break objects when checking language menu items since they don't have a name attribute. Also update the expected result when versioning is enabled to include 'Add Translation' which is now part of the menu with the new django-fsm-2 and versioning integration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add support for Python 3.14 by extending the test matrices, CI configuration, project classifiers, and requirement files, and enhance the pip-tools installation in the compile script.
New Features:
Enhancements:
CI:
Documentation:
Tests: