-
Notifications
You must be signed in to change notification settings - Fork 26
feat: add support for python 3.14 and replace django-fsm to django-fsm-2 #314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR adds Python 3.14 support across CI, project metadata, and test configurations, pins pip-tools upgrades to pip 24.3.1 with system-break flags, and migrates the finite-state machine dependency from django-fsm to django-fsm-2. Entity relationship diagram for new Python 3.14 test requirement fileserDiagram
PY311_REQUIREMENTS {
string name
string version
}
PY312_REQUIREMENTS {
string name
string version
}
PY313_REQUIREMENTS {
string name
string version
}
PY314_REQUIREMENTS {
string name
string version
}
PY314_REQUIREMENTS ||--|| PY311_REQUIREMENTS : "similar structure"
PY314_REQUIREMENTS ||--|| PY312_REQUIREMENTS : "similar structure"
PY314_REQUIREMENTS ||--|| PY313_REQUIREMENTS : "similar structure"
Class diagram for migration from django-fsm to django-fsm-2classDiagram
class FSMField {
+state
+transition()
}
class FSMField2 {
+state
+transition()
+new_features
}
FSMField <|-- FSMField2 : "django-fsm-2 replaces django-fsm"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
for more information, see https://pre-commit.ci
…to feat/python-migration-matrix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there - I've reviewed your changes - here's some feedback:
- I don’t see any actual code changes replacing django-fsm imports or usage with django-fsm-2; please ensure your application code is updated to use the new package and remove old references.
- The new py314 requirement files are almost identical to existing ones—consider templating or generating them to avoid maintaining so many near-duplicate files in the future.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- I don’t see any actual code changes replacing django-fsm imports or usage with django-fsm-2; please ensure your application code is updated to use the new package and remove old references.
- The new py314 requirement files are almost identical to existing ones—consider templating or generating them to avoid maintaining so many near-duplicate files in the future.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Amp-Thread-ID: https://ampcode.com/threads/T-ac7877fd-5037-4683-8f1b-01477304fb76 Co-authored-by: Amp <[email protected]>
Description
Add support for Python 3.14 by extending the test matrices, CI configuration, project classifiers, and requirement files, and enhance the pip-tools installation in the compile script.
New Features:
Enhancements:
CI:
Documentation:
Tests: