Skip to content

Conversation

@vinitkumar
Copy link
Member

@vinitkumar vinitkumar commented Nov 5, 2025

Description

Add support for Python 3.14 by extending the test matrices, CI configuration, project classifiers, and requirement files, and enhance the pip-tools installation in the compile script.

New Features:

  • Support Python 3.14 in test requirement sets across Django and CMS version combinations

Enhancements:

  • Pin pip to version 24.3.1 and add the --break-system-packages flag when installing pip-tools in the compile script

CI:

  • Include Python 3.14 in the GitHub Actions test matrix

Documentation:

  • Add Python 3.14 to the project classifiers in pyproject.toml

Tests:

  • Generate new requirement files for Python 3.14 for all Django and CMS variants

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Nov 5, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR adds Python 3.14 support across CI, project metadata, and test configurations, pins pip-tools upgrades to pip 24.3.1 with system-break flags, and migrates the finite-state machine dependency from django-fsm to django-fsm-2.

Entity relationship diagram for new Python 3.14 test requirement files

erDiagram
  PY311_REQUIREMENTS {
    string name
    string version
  }
  PY312_REQUIREMENTS {
    string name
    string version
  }
  PY313_REQUIREMENTS {
    string name
    string version
  }
  PY314_REQUIREMENTS {
    string name
    string version
  }
  PY314_REQUIREMENTS ||--|| PY311_REQUIREMENTS : "similar structure"
  PY314_REQUIREMENTS ||--|| PY312_REQUIREMENTS : "similar structure"
  PY314_REQUIREMENTS ||--|| PY313_REQUIREMENTS : "similar structure"
Loading

Class diagram for migration from django-fsm to django-fsm-2

classDiagram
  class FSMField {
    +state
    +transition()
  }
  class FSMField2 {
    +state
    +transition()
    +new_features
  }
  FSMField <|-- FSMField2 : "django-fsm-2 replaces django-fsm"
Loading

File-Level Changes

Change Details Files
Add support for Python 3.14 in CI, metadata, and tests
  • Extended compile mappings with 'py314-*' entries
  • Updated GitHub Actions matrix to include Python 3.14
  • Added Python 3.14 classifier in project metadata
  • Created requirement files for all Python 3.14 test scenarios
tests/requirements/compile.py
.github/workflows/test.yml
pyproject.toml
tests/requirements/py314-dj52-cms50-default.txt
tests/requirements/py314-dj52-cms50-versioning.txt
tests/requirements/py314-dj60-cms50-default.txt
tests/requirements/py314-dj60-cms50-versioning.txt
tests/requirements/py314-djmain-cms50-default.txt
tests/requirements/py314-djmain-cms50-versioning.txt
tests/requirements/py314-djmain-cmsdev-default.txt
tests/requirements/py314-djmain-cmsdev-versioning.txt
Pin pip-tools upgrade to specific pip version and enable break-system-packages
  • Pinned pip to 24.3.1 when upgrading pip-tools
  • Enabled '--break-system-packages' flag in the upgrade command
tests/requirements/compile.py
Replace django-fsm with django-fsm-2
  • Updated project dependency to django-fsm-2
  • Replaced import paths and references from django-fsm to django-fsm-2
pyproject.toml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@vinitkumar vinitkumar marked this pull request as ready for review November 5, 2025 15:37
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes - here's some feedback:

  • I don’t see any actual code changes replacing django-fsm imports or usage with django-fsm-2; please ensure your application code is updated to use the new package and remove old references.
  • The new py314 requirement files are almost identical to existing ones—consider templating or generating them to avoid maintaining so many near-duplicate files in the future.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- I don’t see any actual code changes replacing django-fsm imports or usage with django-fsm-2; please ensure your application code is updated to use the new package and remove old references.
- The new py314 requirement files are almost identical to existing ones—consider templating or generating them to avoid maintaining so many near-duplicate files in the future.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants