Open
Conversation
9f28f5c to
82dba3a
Compare
Contributor
Author
|
@fsbraun If I attach the
I have an issue with |
82dba3a to
cfbd392
Compare
Contributor
Author
|
@fsbraun @vinitkumar |
cfbd392 to
0d0fd1c
Compare
Member
|
Hi @mrbazzan I had a look at your PR. A couple of issues here:
Hope, these are helpful. Thank you. |
Contributor
Author
|
Thanks a lot for the feedback!
Okay. I don't actually expect this to get merged, |
0d0fd1c to
c6d0f84
Compare
c6d0f84 to
940392d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Check #150 for details about the issues
Checklist
masterSlack to find a “pr review buddy” who is going to review my pull request.