-
Notifications
You must be signed in to change notification settings - Fork 5
chore: add admin tests #54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's GuideThis PR significantly expands test coverage across the admin interface, model managers, and template tags, and cleans up the GenericDateTaggedManager by removing redundant methods and adding docstrings, as well as tidying up test factories. Class diagram for updated GenericDateTaggedManagerclassDiagram
class GenericDateTaggedManager {
+get_queryset(*args, **kwargs)
+filter_by_language(language, current_site=True)
+on_site(site=None)
+get_months(queryset=None, current_site=True)
}
GenericDateTaggedManager --|> TaggedFilterItem
GenericDateTaggedManager --|> WithUserMixin
GenericDateTaggedManager --|> models.Manager
Class diagram for removed methods in GenericDateTaggedManagerclassDiagram
class GenericDateTaggedManager {
-published(current_site=True)
-published_on_rss(current_site=True)
-available(current_site=True)
-archived(current_site=True)
-published_future(current_site=True)
}
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We encountered an error and are unable to review this PR. We have been notified and are working to fix it.
You can try again by commenting this pull request with @sourcery-ai review, or contact us for help.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #54 +/- ##
=======================================
Coverage 86.57% 86.57%
=======================================
Files 23 23
Lines 2070 2070
Branches 232 232
=======================================
Hits 1792 1792
Misses 186 186
Partials 92 92 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Summary by Sourcery
Add comprehensive test coverage for djangocms_stories admin, managers, and template tags, and for djangocms_blog managers; clean up manager methods and test factories
Enhancements:
Tests:
Chores: