Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add django-tasks-scheduler project #31

Merged
merged 21 commits into from
Aug 5, 2024
Merged

Add django-tasks-scheduler project #31

merged 21 commits into from
Aug 5, 2024

Conversation

cunla
Copy link
Member

@cunla cunla commented Aug 3, 2024

  • Update README accordingly.

Copy link

github-actions bot commented Aug 3, 2024

Terraform plan in terraform
With var files: terraform/production/org.tfvars terraform/production/repositories.tfvars
With variables: github_token = (sensitive value)

Plan: 9 to add, 1 to change, 0 to destroy.
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
+   create
!~  update in-place

Terraform will perform the following actions:

  # github_repository.this["django-tasks-scheduler"] will be updated in-place
!~  resource "github_repository" "this" {
!~      allow_merge_commit          = true -> false
!~      allow_rebase_merge          = true -> false
!~      allow_update_branch         = false -> true
+       archive_on_destroy          = true
!~      delete_branch_on_merge      = false -> true
!~      has_wiki                    = true -> false
        id                          = "django-tasks-scheduler"
!~      merge_commit_message        = "PR_TITLE" -> "PR_BODY"
!~      merge_commit_title          = "MERGE_MESSAGE" -> "PR_TITLE"
        name                        = "django-tasks-scheduler"
!~      squash_merge_commit_message = "COMMIT_MESSAGES" -> "PR_BODY"
!~      squash_merge_commit_title   = "COMMIT_OR_PR_TITLE" -> "PR_TITLE"
#        (27 unchanged attributes hidden)

#        (1 unchanged block hidden)
    }

  # github_team.repo_admin_team["django-tasks-scheduler"] will be created
+   resource "github_team" "repo_admin_team" {
+       create_default_maintainer = false
+       description               = "Admin team for the django-tasks-scheduler repository"
+       etag                      = (known after apply)
+       id                        = (known after apply)
+       members_count             = (known after apply)
+       name                      = "django-tasks-scheduler-admins"
+       node_id                   = (known after apply)
+       parent_team_id            = (known after apply)
+       parent_team_read_id       = (known after apply)
+       parent_team_read_slug     = (known after apply)
+       privacy                   = "closed"
+       slug                      = (known after apply)
    }

  # github_team.repo_committer_team["django-tasks-scheduler"] will be created
+   resource "github_team" "repo_committer_team" {
+       create_default_maintainer = false
+       description               = "Committers team for the django-tasks-scheduler repository"
+       etag                      = (known after apply)
+       id                        = (known after apply)
+       members_count             = (known after apply)
+       name                      = "django-tasks-scheduler-committers"
+       node_id                   = (known after apply)
+       parent_team_id            = (known after apply)
+       parent_team_read_id       = (known after apply)
+       parent_team_read_slug     = (known after apply)
+       privacy                   = "closed"
+       slug                      = (known after apply)
    }

  # github_team.repo_team["django-tasks-scheduler"] will be created
+   resource "github_team" "repo_team" {
+       create_default_maintainer = false
+       description               = "Main team for the django-tasks-scheduler repository"
+       etag                      = (known after apply)
+       id                        = (known after apply)
+       members_count             = (known after apply)
+       name                      = "django-tasks-scheduler"
+       node_id                   = (known after apply)
+       parent_team_read_id       = (known after apply)
+       parent_team_read_slug     = (known after apply)
+       privacy                   = "closed"
+       slug                      = (known after apply)
    }

  # github_team_members.repo_admin_members["django-tasks-scheduler"] will be created
+   resource "github_team_members" "repo_admin_members" {
+       id      = (known after apply)
+       team_id = (known after apply)

+       members {
+           role     = "maintainer"
+           username = "cunla"
        }
    }

  # github_team_members.repo_team_members["django-tasks-scheduler"] will be created
+   resource "github_team_members" "repo_team_members" {
+       id      = (known after apply)
+       team_id = (known after apply)

+       members {
+           role     = "maintainer"
+           username = "cunla"
        }
    }

  # github_team_repository.repo_admin_team_access["django-tasks-scheduler"] will be created
+   resource "github_team_repository" "repo_admin_team_access" {
+       etag       = (known after apply)
+       id         = (known after apply)
+       permission = "admin"
+       repository = "django-tasks-scheduler"
+       team_id    = (known after apply)
    }

  # github_team_repository.repo_committer_team_access["django-tasks-scheduler"] will be created
+   resource "github_team_repository" "repo_committer_team_access" {
+       etag       = (known after apply)
+       id         = (known after apply)
+       permission = "maintain"
+       repository = "django-tasks-scheduler"
+       team_id    = (known after apply)
    }

  # github_team_repository.repo_team_access["django-tasks-scheduler"] will be created
+   resource "github_team_repository" "repo_team_access" {
+       etag       = (known after apply)
+       id         = (known after apply)
+       permission = "triage"
+       repository = "django-tasks-scheduler"
+       team_id    = (known after apply)
    }

  # github_team_settings.this["django-tasks-scheduler"] will be created
+   resource "github_team_settings" "this" {
+       id        = (known after apply)
+       team_id   = (known after apply)
+       team_slug = (known after apply)
+       team_uid  = (known after apply)

+       review_request_delegation {
+           algorithm    = "LOAD_BALANCE"
+           member_count = 2
+           notify       = false
        }
    }

Plan: 9 to add, 1 to change, 0 to destroy.

📝 Plan generated in Plan org changes and list them in a PR #63

@tim-schilling
Copy link
Member

I'll try to look at this tomorrow

@cunla
Copy link
Member Author

cunla commented Aug 3, 2024

No rush.
I was wondering how do we add people in pypi? do we have a team? usernames?

Copy link
Member

@tim-schilling tim-schilling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Mainly only questions for follow-up things and for how we want to maintain this code.

README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
terraform/production/repositories.tfvars Show resolved Hide resolved
cunla and others added 2 commits August 5, 2024 14:33
Co-authored-by: Tim Schilling <[email protected]>
cunla and others added 7 commits August 5, 2024 14:56
@cunla cunla merged commit 844892e into main Aug 5, 2024
@cunla cunla deleted the update-readme branch August 5, 2024 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants