-
Notifications
You must be signed in to change notification settings - Fork 2
refactoring codebase #25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 1888149)
(cherry picked from commit c289d9b)
(cherry picked from commit 95f8542)
(cherry picked from commit 4c6d8f4)
(cherry picked from commit 8d22fc8)
(cherry picked from commit 6c6a206)
(cherry picked from commit 046220b)
by moving `get_server` logic to `get_client`, and adjusting operation methods, same methods can be used with shard as well (cherry picked from commit 21a1ee9)
(cherry picked from commit 61c0220)
(cherry picked from commit 4df4565)
(cherry picked from commit 1ea3331)
(cherry picked from commit 71ffd57)
(cherry picked from commit d924df5)
this was done so people can use them with a raw client (cherry picked from commit d39a5ab)
(cherry picked from commit 772ed71)
(cherry picked from commit 409e95d)
(cherry picked from commit 18ff9a2)
(cherry picked from commit 6327117)
this was left out during cherry-picking
note for future: |
… them also changed how `_incr` handles errors
This was referenced Jun 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is a sub-pr from #24
NOTES:
refactoring invloves these points:
1.moving all client operations into their own class
2.removing shared methods from other clients, and handling all of them in one method (where possible)
3. removing hardcoded (a) prifix from async code and handling that dynamically
4. turning some async methods into sync so both clients can share them
5. reuse normal sync tests for cluster (as much as possible)
6. document the changes