Updated robots.docs.txt for Django 5.0. #1445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixxm
reviewed
Dec 4, 2023
| Disallow: /pt-br/5.0/intro | ||
| Disallow: /pt-br/5.0/ref | ||
| Disallow: /pt-br/5.0/releases | ||
| Disallow: /pt-br/5.0/topics |
There was a problem hiding this comment.
I'm getting a different list when running $ python manage_translations.py robots_txt 🤔
User-agent: *
Disallow: /el/5.0/faq
Disallow: /el/5.0/howto
Disallow: /el/5.0/internals
Disallow: /el/5.0/intro
Disallow: /el/5.0/ref
Disallow: /el/5.0/releases
Disallow: /el/5.0/topics
Disallow: /es/5.0/howto
Disallow: /es/5.0/internals
Disallow: /es/5.0/intro
Disallow: /es/5.0/misc
Disallow: /es/5.0/ref
Disallow: /es/5.0/releases
Disallow: /es/5.0/topics
Disallow: /fr/5.0/releases
Disallow: /id/5.0/internals
Disallow: /id/5.0/ref
Disallow: /id/5.0/releases
Disallow: /id/5.0/topics
Disallow: /it/5.0/internals
Disallow: /it/5.0/ref
Disallow: /it/5.0/releases
Disallow: /it/5.0/topics
Disallow: /ja/5.0/howto
Disallow: /ja/5.0/internals
Disallow: /ja/5.0/misc
Disallow: /ja/5.0/ref
Disallow: /ja/5.0/releases
Disallow: /ja/5.0/topics
Disallow: /ko/5.0/internals
Disallow: /ko/5.0/ref
Disallow: /ko/5.0/releases
Disallow: /ko/5.0/topics
Disallow: /pl/5.0/howto
Disallow: /pl/5.0/internals
Disallow: /pl/5.0/ref
Disallow: /pl/5.0/releases
Disallow: /pl/5.0/topics
Disallow: /pt-br/5.0/howto
Disallow: /pt-br/5.0/internals
Disallow: /pt-br/5.0/intro
Disallow: /pt-br/5.0/ref
Disallow: /pt-br/5.0/releases
Disallow: /pt-br/5.0/topics
Disallow: /zh-hans/5.0/internals
Disallow: /zh-hans/5.0/ref
Disallow: /zh-hans/5.0/releases
Disallow: /zh-hans/5.0/topics
There was a problem hiding this comment.
Weird... I do need to run the command in the stable/5.0.x branch, right? See my output:
[~/fellowship/django-docs-translations stable/5.0.x|✔ ]$ git pull
Enter passphrase for key '***':
Already up to date.
[~/fellowship/django-docs-translations stable/5.0.x|✔ ]$ python manage_translations.py robots_txt
User-agent: *
Disallow: /el/5.0/faq
Disallow: /el/5.0/howto
Disallow: /el/5.0/internals
Disallow: /el/5.0/intro
Disallow: /el/5.0/ref
Disallow: /el/5.0/releases
Disallow: /el/5.0/topics
Disallow: /es/5.0/howto
Disallow: /es/5.0/internals
Disallow: /es/5.0/intro
Disallow: /es/5.0/misc
Disallow: /es/5.0/ref
Disallow: /es/5.0/releases
Disallow: /es/5.0/topics
Disallow: /fr/5.0/releases
Disallow: /id/5.0/internals
Disallow: /id/5.0/ref
Disallow: /id/5.0/releases
Disallow: /id/5.0/topics
Disallow: /it/5.0/internals
Disallow: /it/5.0/ref
Disallow: /it/5.0/releases
Disallow: /it/5.0/topics
Disallow: /ja/5.0/howto
Disallow: /ja/5.0/internals
Disallow: /ja/5.0/misc
Disallow: /ja/5.0/ref
Disallow: /ja/5.0/releases
Disallow: /ja/5.0/topics
Disallow: /ko/5.0/internals
Disallow: /ko/5.0/ref
Disallow: /ko/5.0/releases
Disallow: /ko/5.0/topics
Disallow: /pl/5.0/howto
Disallow: /pl/5.0/internals
Disallow: /pl/5.0/ref
Disallow: /pl/5.0/releases
Disallow: /pl/5.0/topics
Disallow: /pt-br/5.0/howto
Disallow: /pt-br/5.0/internals
Disallow: /pt-br/5.0/intro
Disallow: /pt-br/5.0/ref
Disallow: /pt-br/5.0/releases
Disallow: /pt-br/5.0/topics
Do I need to create a specific virtualenv? 🤔
There was a problem hiding this comment.
I'm not sure why you don't get zh-hans 🤔 These resources are translated in less than 90%
/zh-hans/5.0/internals- 44%/zh-hans/5.0/ref- 81%/zh-hans/5.0/releases- 26%/zh-hans/5.0/topics- 84%
There was a problem hiding this comment.
I'll debug a bit and report back.
There was a problem hiding this comment.
@felixxm I added debug statements and noticed that zh-hans reports 100% translated for all resources (which is clearly incorrect). I'm using msgfmt (GNU gettext-tools) 0.22.3, I'll debug some more.
There was a problem hiding this comment.
I'm out of ideas. I've been googling about this issue with no positive matches. Most posts on stackoverflow agree that msgfmt --statistics should return the amount of translated and untranslated strings. When I run that in both stable/4.2.x and stable/5.0.x, I get the same (no untranslated strings):
$ msgfmt --statistics -cv -o /dev/null translations/zh_Hans/LC_MESSAGES/releases.po
translations/zh_Hans/LC_MESSAGES/releases.po: 7454 translated messages.
What msgfmt version are you running?
There was a problem hiding this comment.
What
msgfmtversion are you running?
0.21
There was a problem hiding this comment.
When running with an older msgfmt, I get the same list as you:
~/fellowship/django-docs-translations$ python3.11 manage_translations.py robots_txt
User-agent: *
Disallow: /el/5.0/faq
Disallow: /el/5.0/howto
Disallow: /el/5.0/internals
Disallow: /el/5.0/intro
Disallow: /el/5.0/ref
Disallow: /el/5.0/releases
Disallow: /el/5.0/topics
Disallow: /es/5.0/howto
Disallow: /es/5.0/internals
Disallow: /es/5.0/intro
Disallow: /es/5.0/misc
Disallow: /es/5.0/ref
Disallow: /es/5.0/releases
Disallow: /es/5.0/topics
Disallow: /fr/5.0/releases
Disallow: /id/5.0/internals
Disallow: /id/5.0/ref
Disallow: /id/5.0/releases
Disallow: /id/5.0/topics
Disallow: /it/5.0/internals
Disallow: /it/5.0/ref
Disallow: /it/5.0/releases
Disallow: /it/5.0/topics
Disallow: /ja/5.0/howto
Disallow: /ja/5.0/internals
Disallow: /ja/5.0/misc
Disallow: /ja/5.0/ref
Disallow: /ja/5.0/releases
Disallow: /ja/5.0/topics
Disallow: /ko/5.0/internals
Disallow: /ko/5.0/ref
Disallow: /ko/5.0/releases
Disallow: /ko/5.0/topics
Disallow: /pl/5.0/howto
Disallow: /pl/5.0/internals
Disallow: /pl/5.0/ref
Disallow: /pl/5.0/releases
Disallow: /pl/5.0/topics
Disallow: /pt-br/5.0/howto
Disallow: /pt-br/5.0/internals
Disallow: /pt-br/5.0/intro
Disallow: /pt-br/5.0/ref
Disallow: /pt-br/5.0/releases
Disallow: /pt-br/5.0/topics
Disallow: /zh-hans/5.0/internals
Disallow: /zh-hans/5.0/ref
Disallow: /zh-hans/5.0/releases
Disallow: /zh-hans/5.0/topics
~/fellowship/django-docs-translations$ msgfmt -V
msgfmt (GNU gettext-tools) 0.19.8.1
Copyright (C) 1995-1998, 2000-2016 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.
Written by Ulrich Drepper.
I'll update the patch and see if I can file a question or issue in the upstream project.
nessita
force-pushed
the
django-5.0-robots
branch
from
291b235
to
bed995b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.