Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Translation preparation for the contact app #1670

Merged
merged 2 commits into from
Nov 17, 2024
Merged

feat: Translation preparation for the contact app #1670

merged 2 commits into from
Nov 17, 2024

Conversation

marksweb
Copy link
Contributor

This adds translations tags to the contact app as suggested in #1648.

bmispelon
bmispelon reviewed Oct 18, 2024
View reviewed changes
Copy link
Member

@bmispelon bmispelon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel I'm repeating myself a bit, but I'll say it again: top-notch work Mark 👍🏻

I had one minor question about the inclusion of → in the string or not, otherwise this looks great.

djangoproject/templates/contact/coc_form.html Outdated Show resolved Hide resolved
djangoproject/templates/contact/foundation.html Outdated Show resolved Hide resolved
@bmispelon bmispelon removed the on hold label Oct 18, 2024
@bmispelon bmispelon removed their assignment Oct 18, 2024
@marksweb
Copy link
Contributor Author

I feel I'm repeating myself a bit, but I'll say it again: top-notch work Mark 👍🏻

I had one minor question about the inclusion of → in the string or not, otherwise this looks great.

Sorry thought I replied to this. I've included the entity ref incase it's appropriate for other language to change it or position it before the word. Thinking mostly RTL languages with that.

bmispelon
bmispelon approved these changes Nov 17, 2024
View reviewed changes
Copy link
Member

@bmispelon bmispelon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@bmispelon bmispelon merged commit 8790d59 into django:main Nov 17, 2024
4 checks passed
@marksweb marksweb deleted the feat/i18n-contact/1648 branch November 17, 2024 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmispelon bmispelon bmispelon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marksweb @bmispelon