Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a link to Individual membership in the site footer #1726

Merged

Conversation

jonafato
Copy link
Contributor

@jonafato jonafato commented Nov 7, 2024

Finding information about Individual membership can be difficult if one does not already know where to look. The current path to this page from the homepage is via the footer at Learn More -> Django Software Foundation -> Individual Members. This change is in the same spirit as pull request #1461, which added a link to the Corporate membership page in the footer for similar discoverability reasons.

Copy link
Member

@bmispelon bmispelon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this makes sense, especially in light of #1461 as you pointed out.

Just have a small suggestion, looks good otherwise.

Thanks for taking the time for this! ✨

djangoproject/templates/includes/footer.html Outdated Show resolved Hide resolved
@jonafato
Copy link
Contributor Author

jonafato commented Nov 7, 2024

@bmispelon Thanks! Suggestion committed.

@bmispelon
Copy link
Member

Oops sorry, that url tag should have been {% url 'members:individual-members' %} (I'd only skimmed the members/urls.py file and missed the app_name).

Glad the tests caught that 😅

Finding information about Individual membership can be difficult if one
does not already know where to look. The current path to this page from
the homepage is via the footer at Learn More -> Django Software
Foundation -> Individual Members. This change is in the same spirit as
pull request django#1461, which added a link to the Corporate membership page
in the footer for similar discoverability reasons.
@jonafato jonafato force-pushed the individual-membership-link-in-footer branch from 97e2775 to 7b415ff Compare November 7, 2024 21:51
@jonafato
Copy link
Contributor Author

jonafato commented Nov 7, 2024

Updated and squashed into a single commit. Hopefully third time's the charm.

Copy link
Member

@bmispelon bmispelon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested things locally and it works (tested both on the www and docs subdomains) 👍🏻

@bmispelon
Copy link
Member

Would you mind filing another PR for the same change on django/code.djangoproject.com? https://github.com/django/code.djangoproject.com/blob/main/trac-env/templates/site_footer.html#L24

(You'll have to hardcode the full URL there, as {% url ... %} won't work)

Thanks! 🚀

jonafato added a commit to jonafato/code.djangoproject.com that referenced this pull request Nov 7, 2024
This is a companion change to go along with the footer updates made to
the main djangoproject.com website at django/djangoproject.com#1726.
@jonafato
Copy link
Contributor Author

jonafato commented Nov 7, 2024

No problem, django/code.djangoproject.com#227

bmispelon pushed a commit to django/code.djangoproject.com that referenced this pull request Nov 8, 2024
This is a companion change to go along with the footer updates made to
the main djangoproject.com website at django/djangoproject.com#1726.
@bmispelon bmispelon merged commit 538d2e6 into django:main Nov 8, 2024
4 checks passed
@bmispelon
Copy link
Member

Both changes are now live, thanks again ✨

@jonafato jonafato deleted the individual-membership-link-in-footer branch November 8, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants