Add attributes ordering to the DStyle #1784
Conversation
|
Thanks for your pull request, @wilzbach! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. |
dstyle.dd
Outdated
| @@ -342,6 +342,7 @@ $(LISTSECTION Attributes, | |||
| matching attributes (`@nogc`, `@safe`, `pure`, `nothrow`).) | |||
| $(LI $(I Templated) functions should $(B not) be annotated with attributes | |||
| as the compiler can infer them.) | |||
| $(LI Attributes should be listed in alphabetical ordering, e.g. `const @nogc nothrow pure @safe`) | |||
There was a problem hiding this comment.
Please also add "(the ordering should ignore the leading @").
wilzbach
force-pushed
the
attributes-order
branch
from
e7d8f02
to
9ffa90f
Compare
Done:
|
|
Great! Once approved, you can merge this yourself. Do you have the appropriate rights? |
I try very hard to not to merge by own PRs ;-)
Yup. |
Merging your own PR after it was approved with suggestions by a member with write access is entirely legit. In fact it's the only possible flow on phabricator. |
As discussed in dlang/phobos#5529 (comment)