fix Issue 20956 - [DIP1000] @safe defeated by closure capturing ref p… #14364
Conversation
|
Thanks for your pull request, @WalterBright! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.
|
| DG forwardDg(ref int c) | ||
| { | ||
| return () {assert(c == 42);}; | ||
| } |
There was a problem hiding this comment.
Shouldn't the compiler infer the closure to be scope in this case ?
Regardless if it does/can infer it currently, we should not have this error for scope delegate, should we ?
There was a problem hiding this comment.
ref parameters are implicitly pointers, and are automatically not allowed to escape the function. No need for scope.
The trouble here is the delegate escapes the function, thereby escaping the reference to c.
There was a problem hiding this comment.
Right, we're returning the delegate. Can we add a test that not escaping the delegate (the delegate being scope) does not trigger error ?
There was a problem hiding this comment.
The error is triggered when the delegate is tested to see if a dynamic closure is being created. So the tests for @nogc already do this.
|
Blocked by dlang/phobos#8530 |
WalterBright
force-pushed
the
fix20956
branch
2 times, most recently
from
1756948
to
0bbc580
Compare
|
I guess the test suite is going to drip-drip-drip the phobos failings one at a time. |
WalterBright
dismissed
dkorpel’s stale review
requires refactoring of other code to implement suggestion
|
Blocked by bugs in Buildkite projects. |
WalterBright
force-pushed
the
fix20956
branch
3 times, most recently
from
1b1c31d
to
36b0a22
Compare
WalterBright
force-pushed
the
fix20956
branch
from
36b0a22
to
e853c99
Compare
…arameter
Very similar to fix for #14363