Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Bugzilla Issue 24784 #16889

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix Bugzilla Issue 24784 #16889

wants to merge 3 commits into from

Conversation

Bolpat
Copy link
Contributor

@Bolpat Bolpat commented Sep 26, 2024

No description provided.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @Bolpat! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
24784 normal Error on first lambda parameter with default with type inference

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#16889"

@thewilsonator
Copy link
Contributor

test case? also pre-commit has failed

@Bolpat
Copy link
Contributor Author

Bolpat commented Sep 27, 2024

@thewilsonator, I added a test case. I have no idea why the pre_commit previously failed.

Another thing I noticed is that on my DMD PRs, circleci quite consistently fails on some _Complex!float and friends. Is that normal or can I do something about it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants