Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(errors): consolidate multiple sarif reports into a single report #17054

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

royalpinto007
Copy link
Contributor

@royalpinto007 royalpinto007 commented Nov 8, 2024

Consolidates multiple SARIF reports into a single report.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @royalpinto007! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#17054"

compiler/src/dmd/errors.d Outdated Show resolved Hide resolved
compiler/src/dmd/errors.d Outdated Show resolved Hide resolved
compiler/src/dmd/errors.d Outdated Show resolved Hide resolved
@royalpinto007 royalpinto007 marked this pull request as draft November 8, 2024 07:24
@royalpinto007 royalpinto007 force-pushed the consolidate-sarif branch 8 times, most recently from 1bba325 to b95a86d Compare November 8, 2024 11:30
Signed-off-by: royalpinto007 <[email protected]>

fix(errors): buffer size

Signed-off-by: royalpinto007 <[email protected]>

fix(errors): diagnostics array

Signed-off-by: royalpinto007 <[email protected]>

fix(errors): repeated sarif blocks in errors.d and sarif.d

Signed-off-by: royalpinto007 <[email protected]>

fix(errors): pre-commit checks

Signed-off-by: royalpinto007 <[email protected]>

fix(errors): circleci build

Signed-off-by: royalpinto007 <[email protected]>

fix(errors): Ddoc comments and docs

Signed-off-by: royalpinto007 <[email protected]>

fix(errors): plugSink function by adding early return for empty diagnostics

Signed-off-by: royalpinto007 <[email protected]>

fix(errors): remove unnecessary change

Signed-off-by: royalpinto007 <[email protected]>

fix(errors): global array initialisation

Signed-off-by: royalpinto007 <[email protected]>

fix(errors): separate formatting message

Signed-off-by: royalpinto007 <[email protected]>

fix(errors): dDoc comments

Signed-off-by: royalpinto007 <[email protected]>
@thewilsonator thewilsonator merged commit dc5f8db into dlang:master Nov 11, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants