fix bugzilla Issue 24861 - Vestige of 16 bit code being accidentally …

[WalterBright]

…generated

[dlang-bot]

Thanks for your pull request, @WalterBright!

Bugzilla references

Auto-close	Bugzilla	Severity	Description
✓	24861	minor	Vestige of 16 bit code being accidentally generated

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#17065"

[braddr]

Given that the dmc front end is dead, there's no testing of the 16 bit backend any more, right? What's the value of keeping untested/able code? I submitted a pull request a while ago to move all the 16 big code generation, it's quite a sizeable amount of code (if I remember right). Collapsing all those conditionals away would certainly help simplify the remaining code, making it that much easier to understand.

[WalterBright]

@braddr Nice to see you here! I've been working on the Aarch64 backend, and indeed the I16 conditionals can get in the way. Fortunately, it's mostly behind if (I16) and those blocks are easily ignored. In fact, what I'd do for starters is to copy the code gen routines, and remove all the I16, I32, 8087, and XMM code. This made converting what remained to Aarch64 much easier.

[braddr]

a little bit rotten:, but not a lot: #16557