Tune FreeBSD timeouts on GitHub Actions #10708
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, our FreeBSD CI tests either complete within about 11 minutes or timeout after 60 mins – ~50 of them spent idling erroneously. The new values are calculated as follows: Timeout taken of DMD's "main" workflow + 5 extra minutes - <https://github.com/dlang/dmd/blob/2036516c1758815739c069a19b0832ef6a0d26e7/.github/workflows/main.yml#L194> - <https://github.com/dlang/dmd/blob/2036516c1758815739c069a19b0832ef6a0d26e7/.github/workflows/main.yml#L201>
|
Thanks for your pull request, @0xEAB! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + phobos#10708" |
thewilsonator
approved these changes
Mar 24, 2025
VPanteleev-S7
pushed a commit
to VPanteleev-S7/phobos
that referenced
this pull request
Jun 5, 2025
Currently, our FreeBSD CI tests either complete within about 11 minutes or timeout after 60 mins – ~50 of them spent idling erroneously. The new values are calculated as follows: Timeout taken of DMD's "main" workflow + 5 extra minutes - <https://github.com/dlang/dmd/blob/2036516c1758815739c069a19b0832ef6a0d26e7/.github/workflows/main.yml#L194> - <https://github.com/dlang/dmd/blob/2036516c1758815739c069a19b0832ef6a0d26e7/.github/workflows/main.yml#L201>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, our FreeBSD CI tests…
I think it wouldn’t hurt to tune this a bit.
The old timeouts seemingly date back to the Cirrus CI to GHA migration and haven’t been adapted since:
https://github.com/dlang/phobos/blame/91af96cddbc6ff23e0453ec31165d7fa85b9100e/.github/workflows/main.yml#L129
The new values are calculated as follows:
$Value\ from\ DMD + 5\ extra\ minutes$
The extra headroom could be remove later on, if practice shows we can tighten thresholds further.