Skip to content

Add video tutorial link #10771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

Mahipalsinh00
Copy link
Contributor

Added a link to a YouTube tutorial to help new contributors set up the D compiler and Phobos development environment.

0xEAB and others added 8 commits April 5, 2025 06:51
* Implement `version (linux_legacy_emulate_getrandom)`

* Fix style
* Add changelog entry for the `getrandom()` backwards compatibility shim

* Comment message pragma of the `getrandom()` backwards compatibility shim
@0xEAB
Copy link
Member

0xEAB commented May 1, 2025

Please removed all unrelated commits from this PR.

AFAICT you might have accidentally created this PR off of the stable branch but submitted it against master. The latter was the correct choice for this enhancement; so that’s great. But please make sure that a feature PR targetting master does not pull in unrelated changes from another branch.

@@ -13,3 +13,5 @@ More Links
* Participate in [our forum](http://forum.dlang.org/)
* Ask questions on our `#d` IRC channel on libera.chat ([web interface](https://kiwiirc.com/client/irc.libera.chat/d))
* Review Phobos additions in the [Review Queue](http://wiki.dlang.org/Review_Queue).

* Video Tutorial: [Setting Up dmd and Phobos for Contribution](https://www.youtube.com/watch?v=iLN4rQkk4Fs&list=PLIldXzSkPUXXSkM5NjBAGNIdkd4Q2Zf0R&index=1&t=1s)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

t=1s — Is there a reason to request the video playback to start with an offset of one second?

@Mahipalsinh00
Copy link
Contributor Author

Thank you for pointing it out. There's no particular reason for the video to start at 1 second — that was unintentional and my mistake.

I've made the necessary correction and opened a clean pull request with only the intended change. Closing this one to avoid confusion.

Replaced by cleaner PR: #10772.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants