Skip to content

std.stdio: Make makeGlobal @trusted #10795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

VPanteleev-S7
Copy link
Contributor

Fixes issue #10794

IDK if it makes sense but a function without arguments seems likely to have a memory-safe interface.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @VPanteleev-S7! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + phobos#10795"

@VPanteleev-S7
Copy link
Contributor Author

Seems this is a known issue (see e.g. the private trustedStdout) and this change is wrong because the return value is ref so it's not thread safe...

@schveiguy
Copy link
Member

see e.g. the private trustedStdout

This is also unsafe.

All this depends on nobody changing stdout from one thread and using it in another. This probably doesn't crash very often because people don't change these handles.

@VPanteleev-S7
Copy link
Contributor Author

Yeah, probably that's why it's private.

@schveiguy
Copy link
Member

Even private use is unsafe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants