Fix compile error in RedBlackTree caused by the presence of a move constructor #10810
+22
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request, @s-ludwig! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "stable + phobos#10810" |
s-ludwig
force-pushed
the
fix_redblacktree_move_constructor
branch
from
417af77 to
5020469
Compare
s-ludwig
force-pushed
the
fix_redblacktree_move_constructor
branch
from
5020469 to
a972a96
Compare
|
Re-targeted to stable. |
thewilsonator
approved these changes
Jun 29, 2025
|
Thanks, could create an issue for this (or link if one already exists). |
|
Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implicitly defined move constructor of
RBNodeshadows the otherwise implicitly defined per-field struct constructor. This could also be considered a language regression, but the fix here is pretty simple and shouldn't otherwise have negative consequences.Fixes #10811.