Skip to content

Fix missing unittests in docs #8603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Oct 16, 2022
Merged

Conversation

ntrel
Copy link
Contributor

@ntrel ntrel commented Oct 15, 2022

Found using dlang/dmd#14527.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @ntrel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + phobos#8603"

@ntrel ntrel marked this pull request as draft October 15, 2022 12:35
@ntrel ntrel changed the title Fix missing staticArray unittest in docs Fix missing unittests in docs Oct 15, 2022
@ntrel ntrel marked this pull request as ready for review October 16, 2022 11:01
@ntrel
Copy link
Contributor Author

ntrel commented Oct 16, 2022

Updated. There are some more to fix but I've stalled on this right now so marked as ready.

@ntrel ntrel marked this pull request as draft October 16, 2022 17:09
@ntrel
Copy link
Contributor Author

ntrel commented Oct 16, 2022

I think private undocumented symbols should be ignored when matching a documented unittest to a symbol (https://issues.dlang.org/show_bug.cgi?id=17678). So I've removed four changes that should be unnecessary if that is implemented.

@ntrel ntrel marked this pull request as ready for review October 16, 2022 17:27
@thewilsonator thewilsonator merged commit 281f42d into dlang:master Oct 16, 2022
@ntrel ntrel deleted the staticArray-doc branch October 17, 2022 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants